]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
[PATCH] libata-dev: irq-pio minor fix
authorAlbert Lee <albertcc@tw.ibm.com>
Mon, 3 Apr 2006 09:43:24 +0000 (17:43 +0800)
committerJeff Garzik <jeff@garzik.org>
Tue, 4 Apr 2006 12:42:25 +0000 (08:42 -0400)
irq-pio minor fix:
- remove the redundant hsm_task_state = HSM_ST_IDLE
- add devno to printk() as done in upstream

Signed-off-by: Albert Lee <albertcc@tw.ibm.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/scsi/libata-core.c
drivers/scsi/libata-eh.c

index 56537293ad4139661f8583ce2c41c71c5182e238..d270b23a03b8d8a2909015c764cc864ce11cb08e 100644 (file)
@@ -4043,8 +4043,8 @@ fsm_start:
                }
 
                /* no more data to transfer */
-               DPRINTK("ata%u: command complete, drv_stat 0x%x\n",
-                       ap->id, status);
+               DPRINTK("ata%u: dev %u command complete, drv_stat 0x%x\n",
+                       ap->id, qc->dev->devno, status);
 
                WARN_ON(qc->err_mask);
 
@@ -4061,8 +4061,8 @@ fsm_start:
 
        case HSM_ST_ERR:
                if (qc->tf.command != ATA_CMD_PACKET)
-                       printk(KERN_ERR "ata%u: command error, drv_stat 0x%x\n",
-                              ap->id, status);
+                       printk(KERN_ERR "ata%u: dev %u command error, drv_stat 0x%x\n",
+                              ap->id, qc->dev->devno, status);
 
                /* make sure qc->err_mask is available to
                 * know what's wrong and recover
index 011e083b19e1063787aa5d7d2d16b9e675198699..9a8eea11b0be30f8aff9437b0d7c3a58226f3ed1 100644 (file)
@@ -137,7 +137,6 @@ int ata_scsi_error(struct Scsi_Host *host)
  *     LOCKING:
  *     Inherited from SCSI layer (none, can sleep)
  */
-
 static void ata_qc_timeout(struct ata_queued_cmd *qc)
 {
        struct ata_port *ap = qc->ap;
@@ -172,8 +171,6 @@ static void ata_qc_timeout(struct ata_queued_cmd *qc)
                printk(KERN_ERR "ata%u: command 0x%x timeout, stat 0x%x host_stat 0x%x\n",
                       ap->id, qc->tf.command, drv_stat, host_stat);
 
-               ap->hsm_task_state = HSM_ST_IDLE;
-
                /* complete taskfile transaction */
                qc->err_mask |= AC_ERR_TIMEOUT;
                break;