]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
loop-cleanup-partitions-when-detaching-loop-device-checkpatch-fixes
authorAndrew Morton <akpm@linux-foundation.org>
Wed, 20 Mar 2013 04:07:00 +0000 (15:07 +1100)
committerStephen Rothwell <sfr@canb.auug.org.au>
Thu, 21 Mar 2013 05:28:21 +0000 (16:28 +1100)
ERROR: that open brace { should be on the previous line
#32: FILE: drivers/block/loop.c:1051:
+ if (bdev)
+ {

WARNING: line over 80 characters
#39: FILE: drivers/block/loop.c:1058:
+ disk_part_iter_init(&piter, bdev->bd_disk, DISK_PITER_INCL_EMPTY);

total: 1 errors, 1 warnings, 26 lines checked

./patches/loop-cleanup-partitions-when-detaching-loop-device.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Jens Axboe <axboe@kernel.dk>
Cc: Phillip Susi <psusi@ubuntu.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
drivers/block/loop.c

index 738cb0c6f9c3d2bef2b6953b5333ee62100e3d75..e9aaddba763f96f45b1b288fa638c15105643f1e 100644 (file)
@@ -1048,8 +1048,7 @@ static int loop_clr_fd(struct loop_device *lo)
        if (!part_shift)
                lo->lo_disk->flags |= GENHD_FL_NO_PART_SCAN;
        mutex_unlock(&lo->lo_ctl_mutex);
-       if (bdev)
-       {
+       if (bdev) {
                struct disk_part_iter piter;
                struct hd_struct *part;