]> git.karo-electronics.de Git - linux-beck.git/commitdiff
leds: leds-mc13783: Use of_get_child_by_name() instead of refcount hack
authorGeert Uytterhoeven <geert+renesas@glider.be>
Wed, 14 Jan 2015 13:51:58 +0000 (05:51 -0800)
committerBryan Wu <cooloney@gmail.com>
Wed, 14 Jan 2015 18:40:20 +0000 (10:40 -0800)
of_find_node_by_name() calls of_node_put() on its "from" parameter.
To counter this, mc13xxx_led_probe_dt() calls of_node_get() first.

Use of_get_child_by_name() instead to get rid of the refcount hack.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: linux-leds@vger.kernel.org
Signed-off-by: Bryan Wu <cooloney@gmail.com>
drivers/leds/leds-mc13783.c

index 85c3714e1b5aabbad081e64f6e3e22abd2e2f444..e2b847fe22a1c9343d1bb37020000b470ccd7ff7 100644 (file)
@@ -134,9 +134,7 @@ static struct mc13xxx_leds_platform_data __init *mc13xxx_led_probe_dt(
        if (!pdata)
                return ERR_PTR(-ENOMEM);
 
-       of_node_get(dev->parent->of_node);
-
-       parent = of_find_node_by_name(dev->parent->of_node, "leds");
+       parent = of_get_child_by_name(dev->parent->of_node, "leds");
        if (!parent)
                goto out_node_put;