]> git.karo-electronics.de Git - linux-beck.git/commitdiff
qlcnic: Correct off-by-one errors in bounds checks
authorManish Chopra <manish.chopra@qlogic.com>
Tue, 28 Jan 2014 16:55:27 +0000 (11:55 -0500)
committerDavid S. Miller <davem@davemloft.net>
Tue, 28 Jan 2014 19:59:30 +0000 (11:59 -0800)
o Bound checks should be >= instead of > for number of receive descriptors
  and number of receive rings.

Signed-off-by: Manish Chopra <manish.chopra@qlogic.com>
Signed-off-by: Jitendra Kalsaria <jitendra.kalsaria@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c

index 30874cda84764996735d2a070ab45516311e8def..19e1a93bac67439e51d96c275abbc03e28a8f9df 100644 (file)
@@ -1150,13 +1150,13 @@ qlcnic_process_lro(struct qlcnic_adapter *adapter,
        u16 lro_length, length, data_offset, t_vid, vid = 0xffff;
        u32 seq_number;
 
-       if (unlikely(ring > adapter->max_rds_rings))
+       if (unlikely(ring >= adapter->max_rds_rings))
                return NULL;
 
        rds_ring = &recv_ctx->rds_rings[ring];
 
        index = qlcnic_get_lro_sts_refhandle(sts_data0);
-       if (unlikely(index > rds_ring->num_desc))
+       if (unlikely(index >= rds_ring->num_desc))
                return NULL;
 
        buffer = &rds_ring->rx_buf_arr[index];
@@ -1662,13 +1662,13 @@ qlcnic_83xx_process_lro(struct qlcnic_adapter *adapter,
        u16 vid = 0xffff;
        int err;
 
-       if (unlikely(ring > adapter->max_rds_rings))
+       if (unlikely(ring >= adapter->max_rds_rings))
                return NULL;
 
        rds_ring = &recv_ctx->rds_rings[ring];
 
        index = qlcnic_83xx_hndl(sts_data[0]);
-       if (unlikely(index > rds_ring->num_desc))
+       if (unlikely(index >= rds_ring->num_desc))
                return NULL;
 
        buffer = &rds_ring->rx_buf_arr[index];