]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
xen/xenbus: Check before dereferencing it.
authorKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Thu, 29 Sep 2011 17:16:17 +0000 (13:16 -0400)
committerKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Thu, 29 Sep 2011 18:33:29 +0000 (14:33 -0400)
.. we do the check whether 'xdev' is NULL - but after we have
dereferenced it.

Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
drivers/xen/xenbus/xenbus_probe_backend.c

index 60adf919d78ddd46a4e6e2cadad27bd053bfa392..331589afcfb4605a995c98137c5602c07d50d6b7 100644 (file)
@@ -103,10 +103,11 @@ static int xenbus_uevent_backend(struct device *dev,
                return -ENODEV;
 
        xdev = to_xenbus_device(dev);
-       bus = container_of(xdev->dev.bus, struct xen_bus_type, bus);
        if (xdev == NULL)
                return -ENODEV;
 
+       bus = container_of(xdev->dev.bus, struct xen_bus_type, bus);
+
        if (add_uevent_var(env, "MODALIAS=xen-backend:%s", xdev->devicetype))
                return -ENOMEM;