]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
x86, hpet: Fix bogus error check in hpet_assign_irq()
authorThomas Gleixner <tglx@linutronix.de>
Tue, 28 Sep 2010 21:20:23 +0000 (23:20 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 29 Oct 2010 04:43:59 +0000 (21:43 -0700)
commit 021989622810b02aab4b24f91e1f5ada2b654579 upstream.

create_irq() returns -1 if the interrupt allocation failed, but the
code checks for irq == 0.

Use create_irq_nr() instead.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Venkatesh Pallipadi <venki@google.com>
LKML-Reference: <alpine.LFD.2.00.1009282310360.2416@localhost6.localdomain6>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
arch/x86/kernel/hpet.c

index 19528ef10d311f6bbd31402edfa39a4ae253eaeb..c771e1a37b9de8d7b5f81d79dd6cd33f6ab28e72 100644 (file)
@@ -497,7 +497,7 @@ static int hpet_assign_irq(struct hpet_dev *dev)
 {
        unsigned int irq;
 
-       irq = create_irq();
+       irq = create_irq_nr(0, -1);
        if (!irq)
                return -EINVAL;