]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
serial: mxs: fix buffer overflow
authorWolfram Sang <wsa@the-dreams.de>
Fri, 19 Apr 2013 19:12:17 +0000 (21:12 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 22 Apr 2013 17:22:21 +0000 (10:22 -0700)
SMATCH correctly found an off-by-one error:

drivers/tty/serial/mxs-auart.c:889 auart_console_write() error: buffer overflow 'auart_port' 5 <= 5

Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/mxs-auart.c

index d549fe1fa42abdce8611645d1038dfb11b5e0654..9d357da817ded1ad682a83a5b51032bdd15717a5 100644 (file)
@@ -883,7 +883,7 @@ auart_console_write(struct console *co, const char *str, unsigned int count)
        unsigned int old_ctrl0, old_ctrl2;
        unsigned int to = 1000;
 
-       if (co->index > MXS_AUART_PORTS || co->index < 0)
+       if (co->index >= MXS_AUART_PORTS || co->index < 0)
                return;
 
        s = auart_port[co->index];