ipv6: reject locally assigned nexthop addresses

ip -6 addr add dead::1/128 dev eth0
sleep 5
ip -6 route add default via dead::1/128
-> fails
ip -6 addr add dead::1/128 dev eth0
ip -6 route add default via dead::1/128
-> succeeds

reason is that if (nonsensensical) route above is added,
dead::1 is still subject to DAD, so the route lookup will
pick eth0 as outdev due to the prefix route that is added before
DAD work is started.

Add explicit test that checks if nexthop gateway is a local address.

Link: https://bugzilla.redhat.com/show_bug.cgi?id=1167969
Signed-off-by: Florian Westphal <fw@strlen.de>
Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 6f4a35096bdeb207a8e717b10e4625db90351df2..98fce6f4a580b91085440405e594104490879759 100644 (file)
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -1624,6 +1624,16 @@ int ip6_route_add(struct fib6_config *cfg)
                int gwa_type;
 
                gw_addr = &cfg->fc_gateway;
+
+               /* if gw_addr is local we will fail to detect this in case
+                * address is still TENTATIVE (DAD in progress). rt6_lookup()
+                * will return already-added prefix route via interface that
+                * prefix route was assigned to, which might be non-loopback.
+                */
+               err = -EINVAL;
+               if (ipv6_chk_addr_and_flags(net, gw_addr, NULL, 0, 0))
+                       goto out;
+
                rt->rt6i_gateway = *gw_addr;
                gwa_type = ipv6_addr_type(gw_addr);
 
@@ -1637,7 +1647,6 @@ int ip6_route_add(struct fib6_config *cfg)
                           (SIT, PtP, NBMA NOARP links) it is handy to allow
                           some exceptions. --ANK
                         */
-                       err = -EINVAL;
                        if (!(gwa_type & IPV6_ADDR_UNICAST))
                                goto out;