]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
hwmon: (w83627hf) Don't touch nonexistent I2C address registers
authorJean Delvare <khali@linux-fr.org>
Tue, 13 Nov 2012 23:31:27 +0000 (10:31 +1100)
committerStephen Rothwell <sfr@canb.auug.org.au>
Tue, 13 Nov 2012 23:31:27 +0000 (10:31 +1100)
Only the W83627HF could be accessed through I2C. All other supported
chips are LPC-only, so they do not have I2C address registers. Don't
write to nonexistent or reserved registers on these chips.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Acked-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/w83627hf.c

index b8851f76265da433007c4ad14b754e19c41647db..060d4ce8047a40b2163b3b8cab3052221c2f4a48 100644 (file)
@@ -1732,8 +1732,10 @@ static void __devinit w83627hf_init_device(struct platform_device *pdev)
        /* Minimize conflicts with other winbond i2c-only clients...  */
        /* disable i2c subclients... how to disable main i2c client?? */
        /* force i2c address to relatively uncommon address */
-       w83627hf_write_value(data, W83781D_REG_I2C_SUBADDR, 0x89);
-       w83627hf_write_value(data, W83781D_REG_I2C_ADDR, force_i2c);
+       if (type == w83627hf) {
+               w83627hf_write_value(data, W83781D_REG_I2C_SUBADDR, 0x89);
+               w83627hf_write_value(data, W83781D_REG_I2C_ADDR, force_i2c);
+       }
 
        /* Read VID only once */
        if (type == w83627hf || type == w83637hf) {