]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
ASoC: uda1380: Remove #if IS_ENABLED(CONFIG_I2C)
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Thu, 17 Nov 2016 01:12:30 +0000 (01:12 +0000)
committerMark Brown <broonie@kernel.org>
Fri, 18 Nov 2016 12:05:47 +0000 (12:05 +0000)
uda1380 driver doesn't work without CONFIG_I2C anyway.
Let's remove #if IS_ENABLED(CONFIG_I2C), and use module_i2c_driver().

And, this patch adds "depends on I2C" to Kconfig

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/Kconfig
sound/soc/codecs/uda1380.c

index c67667bb970f1729db65b027dd8e963b9ee95b7b..98b9a0c35d6b1c7e70c862437d44b41162028ab1 100644 (file)
@@ -874,6 +874,7 @@ config SND_SOC_UDA134X
 
 config SND_SOC_UDA1380
         tristate
+       depends on I2C
 
 config SND_SOC_WL1273
        tristate
index 533e3bb444e4d2ee05ee6772db636539cb726af0..8e52439a58fda9ddbce5fa860038c834cef4dd64 100644 (file)
@@ -775,7 +775,6 @@ static struct snd_soc_codec_driver soc_codec_dev_uda1380 = {
        },
 };
 
-#if IS_ENABLED(CONFIG_I2C)
 static int uda1380_i2c_probe(struct i2c_client *i2c,
                             const struct i2c_device_id *id)
 {
@@ -815,27 +814,8 @@ static struct i2c_driver uda1380_i2c_driver = {
        .remove =   uda1380_i2c_remove,
        .id_table = uda1380_i2c_id,
 };
-#endif
 
-static int __init uda1380_modinit(void)
-{
-       int ret = 0;
-#if IS_ENABLED(CONFIG_I2C)
-       ret = i2c_add_driver(&uda1380_i2c_driver);
-       if (ret != 0)
-               pr_err("Failed to register UDA1380 I2C driver: %d\n", ret);
-#endif
-       return ret;
-}
-module_init(uda1380_modinit);
-
-static void __exit uda1380_exit(void)
-{
-#if IS_ENABLED(CONFIG_I2C)
-       i2c_del_driver(&uda1380_i2c_driver);
-#endif
-}
-module_exit(uda1380_exit);
+module_i2c_driver(uda1380_i2c_driver);
 
 MODULE_AUTHOR("Giorgio Padrin");
 MODULE_DESCRIPTION("Audio support for codec Philips UDA1380");