]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
dt: dbx5x0: remove mentor,musb binding
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Tue, 20 Aug 2013 16:40:27 +0000 (18:40 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Thu, 26 Sep 2013 09:04:02 +0000 (11:04 +0200)
The "mentor,musb" binding isn't documented so I was about
to document it.

The node is missing a few properties for configuration like
"multipoint", "dyn_fifo", "num_eps" or "ram_bits". However
I am not sure "missing" is the right word here because some
of those informations might be obtained from the chip itself
but it is not done (yet).

Further the ePARP 2.3.1 says the matching goes from left to
right taking the fist match. Right now there is jus a driver
for "stericsson,db8500-musb" and none for "mentor,musb".
I'm not 100% that it is simply possible to have a generic
since even for DMA we have ifdefs in the driver between
"generic mentor dma" and "ux500 dma" and I mean within musb
and not the dma code.

For that reason (that I am not sure a generic musb binding
is possible and how its binding / required properties will
look like) and the reason that we have here a minor binding
without a driver to look at I suggest to remove that binding.

If the majority of people prefer to keep this binding I'm
curious how the documentation of the binding should look like.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Documentation/devicetree/bindings/usb/ux500-usb.txt
arch/arm/boot/dts/ste-dbx5x0.dtsi

index 330d6ec154016caf4bccd0a5bde0d36847412fcb..439a41c79afacd680a6c8309935ab37573cd6326 100644 (file)
@@ -15,7 +15,7 @@ Optional properties:
 Example:
 
 usb_per5@a03e0000 {
-       compatible = "stericsson,db8500-musb", "mentor,musb";
+       compatible = "stericsson,db8500-musb";
        reg = <0xa03e0000 0x10000>;
        interrupts = <0 23 0x4>;
        interrupt-names = "mc";
index 0c1338e36a837e56f22410616e10625327eaaadd..111d062dc8ccfd2a973419bef75b70ab687320ad 100644 (file)
                };
 
                usb_per5@a03e0000 {
-                       compatible = "stericsson,db8500-musb",
-                               "mentor,musb";
+                       compatible = "stericsson,db8500-musb";
                        reg = <0xa03e0000 0x10000>;
                        interrupts = <0 23 IRQ_TYPE_LEVEL_HIGH>;
                        interrupt-names = "mc";