]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
s390/qeth: don't convert return code twice
authorJulian Wiedmann <jwi@linux.vnet.ibm.com>
Thu, 12 Jan 2017 14:48:38 +0000 (15:48 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 12 Jan 2017 15:02:43 +0000 (10:02 -0500)
qeth_l2_send_groupmac() already translates the return code, so
calling qeth_setdel_makerc() a second time only produces garbage.

Signed-off-by: Julian Wiedmann <jwi@linux.vnet.ibm.com>
Reviewed-by: Thomas Richter <tmricht@linux.vnet.ibm.com>
Reviewed-by: Ursula Braun <ubraun@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/s390/net/qeth_l2_main.c

index 3025f56319e2e57df46ec46470a4dbce4fb64653..38fae10b347943c42aae0a07a91fdf5de77a30ad 100644 (file)
@@ -210,8 +210,7 @@ static int qeth_l2_write_mac(struct qeth_card *card, struct qeth_mac *mac)
                                qeth_l2_send_setdelmac(card, mac->mac_addr,
                                                IPA_CMD_SETVMAC));
        } else {
-               rc = qeth_setdel_makerc(card,
-                               qeth_l2_send_setgroupmac(card, mac->mac_addr));
+               rc = qeth_l2_send_setgroupmac(card, mac->mac_addr);
        }
        return rc;
 }