]> git.karo-electronics.de Git - linux-beck.git/commitdiff
vt: vt_ioctl: use msecs_to_jiffies for time conversion
authorNicholas Mc Guire <hofrat@osadl.org>
Mon, 9 Feb 2015 15:53:25 +0000 (10:53 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 7 Mar 2015 03:02:26 +0000 (04:02 +0100)
Converting milliseconds to jiffies by "val * HZ / 1000" is technically
OK but msecs_to_jiffies(val) is the cleaner solution and handles all
corner cases correctly. This is a minor API consolidation only and
should make things more readable.

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/vt/vt_ioctl.c

index 2bd78e2ac8ecba07dbf42788b6c61506ee8b2b20..97d5a74558a3a4477e3c5cfb29dd88591fefbe92 100644 (file)
@@ -388,7 +388,7 @@ int vt_ioctl(struct tty_struct *tty,
                 * Generate the tone for the appropriate number of ticks.
                 * If the time is zero, turn off sound ourselves.
                 */
-               ticks = HZ * ((arg >> 16) & 0xffff) / 1000;
+               ticks = msecs_to_jiffies((arg >> 16) & 0xffff);
                count = ticks ? (arg & 0xffff) : 0;
                if (count)
                        count = PIT_TICK_RATE / count;