]> git.karo-electronics.de Git - linux-beck.git/commitdiff
drm/mgag200: Remove unecessary NULL check in gem_free
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Sat, 5 Apr 2014 08:06:16 +0000 (10:06 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 22 Apr 2014 13:39:04 +0000 (15:39 +0200)
The ->gem_free_object never gets called with a NULL pointer, the check
is redundant. Also checking after the upcast allows compilers to elide
it anyway.

Spotted by coverity.

Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/mgag200/mgag200_main.c

index 0722d18992f48feed4c96fe6a037bcce9b235c7f..f6b283b8375ec7071adb32459a1bc2f6427dc2ad 100644 (file)
@@ -329,8 +329,6 @@ void mgag200_gem_free_object(struct drm_gem_object *obj)
 {
        struct mgag200_bo *mgag200_bo = gem_to_mga_bo(obj);
 
-       if (!mgag200_bo)
-               return;
        mgag200_bo_unref(&mgag200_bo);
 }