]> git.karo-electronics.de Git - linux-beck.git/commitdiff
net: cpsw: Add missing return value
authorMarkus Pargmann <mpa@pengutronix.de>
Mon, 29 Sep 2014 06:53:14 +0000 (08:53 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 30 Sep 2014 05:30:42 +0000 (01:30 -0400)
ret is set 0 at this point, so jumping to that error label would result
in a return value of 0. Set ret to -ENOMEM to return a proper error
value.

Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
Reviewed-by: Wolfram Sang <wsa@the-dreams.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ti/cpsw.c

index 45ba50e4eaec389a5103a54229d908421ce16553..187c6ef548853f3b0e152269fa0d905aaccec6b5 100644 (file)
@@ -2123,6 +2123,7 @@ static int cpsw_probe(struct platform_device *pdev)
        priv->irq_enabled = true;
        if (!priv->cpts) {
                dev_err(&pdev->dev, "error allocating cpts\n");
+               ret = -ENOMEM;
                goto clean_ndev_ret;
        }