]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
staging: greybus: uart: fix invalid user-pointer check
authorJohan Hovold <johan@kernel.org>
Tue, 8 Nov 2016 12:31:18 +0000 (13:31 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 10 Nov 2016 13:04:12 +0000 (14:04 +0100)
Drop invalid user-pointer check from TIOCGSERIAL handler.

A NULL-pointer can be valid in user space and copy_to_user() takes care
of sanity checking.

Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/greybus/uart.c

index c1f6abb57dc3bd3272337362df31d74fd52f5aa1..35755f70d5a2f737e6f95eebde4985b7375babdd 100644 (file)
@@ -623,9 +623,6 @@ static int get_serial_info(struct gb_tty *gb_tty,
 {
        struct serial_struct tmp;
 
-       if (!info)
-               return -EINVAL;
-
        memset(&tmp, 0, sizeof(tmp));
        tmp.flags = ASYNC_LOW_LATENCY | ASYNC_SKIP_TEST;
        tmp.type = PORT_16550A;