]> git.karo-electronics.de Git - linux-beck.git/commitdiff
staging: wlang-ng: avoid new typedef: hfa384x_pdrec_t
authorSergio Paracuellos <sergio.paracuellos@gmail.com>
Wed, 28 Sep 2016 18:20:13 +0000 (20:20 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 2 Oct 2016 15:03:56 +0000 (17:03 +0200)
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs

It applies for typedef hfa384x_pdrec_t

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wlan-ng/hfa384x.h
drivers/staging/wlan-ng/prism2fw.c

index 45bc4a8be53291736dd62082275cc8ddac08bfd8..57c394d05d9aba2ef5469170b090f0ab832aaaeb 100644 (file)
@@ -1090,7 +1090,7 @@ struct hfa384x_pdr_end_of_pda {
        u16 crc;
 } __packed;
 
-typedef struct hfa384x_pdrec {
+struct hfa384x_pdrec {
        u16 len;                /* in words */
        u16 code;
        union pdr {
@@ -1130,7 +1130,7 @@ typedef struct hfa384x_pdrec {
                struct hfa384x_pdr_end_of_pda end_of_pda;
 
        } data;
-} __packed hfa384x_pdrec_t;
+} __packed;
 
 #ifdef __KERNEL__
 /*--------------------------------------------------------------------
index ca322fa3d43cf10fcd26b135fc3589ee7c8901b4..96aa21188669d34d3d03e703c6659dafbddb855c 100644 (file)
@@ -105,7 +105,7 @@ struct s3inforec {
 
 struct pda {
        u8 buf[HFA384x_PDA_LEN_MAX];
-       hfa384x_pdrec_t *rec[HFA384x_PDA_RECS_MAX];
+       struct hfa384x_pdrec *rec[HFA384x_PDA_RECS_MAX];
        unsigned int nrec;
 };
 
@@ -266,7 +266,7 @@ static int prism2_fwapply(const struct ihex_binrec *rfptr,
 
        /* clear the pda and add an initial END record */
        memset(&pda, 0, sizeof(pda));
-       pda.rec[0] = (hfa384x_pdrec_t *)pda.buf;
+       pda.rec[0] = (struct hfa384x_pdrec *)pda.buf;
        pda.rec[0]->len = cpu_to_le16(2);       /* len in words */
        pda.rec[0]->code = cpu_to_le16(HFA384x_PDR_END_OF_PDA);
        pda.nrec = 1;
@@ -599,7 +599,7 @@ static int mkpdrlist(struct pda *pda)
        curroff = 0;
        while (curroff < (HFA384x_PDA_LEN_MAX / 2 - 1) &&
               le16_to_cpu(pda16[curroff + 1]) != HFA384x_PDR_END_OF_PDA) {
-               pda->rec[pda->nrec] = (hfa384x_pdrec_t *)&(pda16[curroff]);
+               pda->rec[pda->nrec] = (struct hfa384x_pdrec *)&(pda16[curroff]);
 
                if (le16_to_cpu(pda->rec[pda->nrec]->code) ==
                    HFA384x_PDR_NICID) {
@@ -638,7 +638,7 @@ static int mkpdrlist(struct pda *pda)
                       curroff, pda->nrec);
                return 1;
        }
-       pda->rec[pda->nrec] = (hfa384x_pdrec_t *)&(pda16[curroff]);
+       pda->rec[pda->nrec] = (struct hfa384x_pdrec *)&(pda16[curroff]);
        (pda->nrec)++;
        return 0;
 }