]> git.karo-electronics.de Git - linux-beck.git/commitdiff
perf evlist: Use bool instead of target argument in propagate_maps()
authorJiri Olsa <jolsa@kernel.org>
Tue, 21 Jul 2015 12:31:28 +0000 (14:31 +0200)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 21 Jul 2015 17:34:07 +0000 (14:34 -0300)
We need only bool info wether user defined her own set of cpus.

Switching target argument to bool so it could be used from places
without target object defined in following patches.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1437481927-29538-9-git-send-email-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/evlist.c

index 6bfcab9b7108e65228e7b40c1fc5c280c45531d4..80ab942afa8ab03d0b8a43c0acf9580908f1d443 100644 (file)
@@ -1102,7 +1102,7 @@ int perf_evlist__mmap(struct perf_evlist *evlist, unsigned int pages,
 }
 
 static int perf_evlist__propagate_maps(struct perf_evlist *evlist,
-                                      struct target *target)
+                                      bool has_user_cpus)
 {
        struct perf_evsel *evsel;
 
@@ -1111,10 +1111,10 @@ static int perf_evlist__propagate_maps(struct perf_evlist *evlist,
                 * We already have cpus for evsel (via PMU sysfs) so
                 * keep it, if there's no target cpu list defined.
                 */
-               if (evsel->cpus && target->cpu_list)
+               if (evsel->cpus && has_user_cpus)
                        cpu_map__put(evsel->cpus);
 
-               if (!evsel->cpus || target->cpu_list)
+               if (!evsel->cpus || has_user_cpus)
                        evsel->cpus = cpu_map__get(evlist->cpus);
 
                evsel->threads = thread_map__get(evlist->threads);
@@ -1142,7 +1142,7 @@ int perf_evlist__create_maps(struct perf_evlist *evlist, struct target *target)
        if (evlist->cpus == NULL)
                goto out_delete_threads;
 
-       return perf_evlist__propagate_maps(evlist, target);
+       return perf_evlist__propagate_maps(evlist, !!target->cpu_list);
 
 out_delete_threads:
        thread_map__put(evlist->threads);