]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
greybus: svc: return proper error code on watchdog create error
authorGreg Kroah-Hartman <gregkh@google.com>
Sun, 24 Jan 2016 01:36:00 +0000 (17:36 -0800)
committerGreg Kroah-Hartman <gregkh@google.com>
Sun, 24 Jan 2016 01:38:45 +0000 (17:38 -0800)
When the watchdog is not created properly, we need to propagate the
error for this and not just return success.

Reported-by: Rui Miguel Silva <rui.silva@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
drivers/staging/greybus/svc.c

index fc574703172101e880e1d18648ba5a6343080af3..9df3c7a4bb82ca6a850cf191e6e31d165a118e2e 100644 (file)
@@ -441,6 +441,7 @@ static int gb_svc_hello(struct gb_operation *op)
                dev_err(&svc->dev, "failed to create watchdog: %d\n", ret);
                input_unregister_device(svc->input);
                device_del(&svc->dev);
+               return ret;
        }
 
        return 0;