]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
libata: set dma_mode to 0xff in reset
authorAaron Lu <aaron.lu@intel.com>
Mon, 3 Dec 2012 03:35:02 +0000 (11:35 +0800)
committerJeff Garzik <jgarzik@redhat.com>
Mon, 3 Dec 2012 10:07:13 +0000 (05:07 -0500)
ata_device->dma_mode's initial value is zero, which is not a valid dma
mode, but ata_dma_enabled will return true for this value. This patch
sets dma_mode to 0xff in reset function, so that ata_dma_enabled will
not return true for this case, or it will cause problem for pata_acpi.

The corrsponding bugzilla page is at:
https://bugzilla.kernel.org/show_bug.cgi?id=49151

Reported-by: Phillip Wood <phillip.wood@dunelm.org.uk>
Signed-off-by: Aaron Lu <aaron.lu@intel.com>
Tested-by: Szymon Janc <szymon@janc.net.pl>
Tested-by: Dutra Julio <dutra.julio@gmail.com>
Acked-by: Alan Cox <alan@linux.intel.com>
Cc: <stable@kernel.org>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
drivers/ata/libata-core.c
drivers/ata/libata-eh.c

index caffe73c1e4a1bfb559f0ef3d2f56e69f1b6d7dc..583f26d6d455a34533c73ff13d66b2019a3d312b 100644 (file)
@@ -2559,6 +2559,7 @@ int ata_bus_probe(struct ata_port *ap)
                 * bus as we may be talking too fast.
                 */
                dev->pio_mode = XFER_PIO_0;
+               dev->dma_mode = 0xff;
 
                /* If the controller has a pio mode setup function
                 * then use it to set the chipset to rights. Don't
index e60437cd0d192efeb68ffdb93c7e0fd0a0f62423..bf039b0e97b79d7f9c9d2bae803ad84850b181b4 100644 (file)
@@ -2657,6 +2657,7 @@ int ata_eh_reset(struct ata_link *link, int classify,
                 * bus as we may be talking too fast.
                 */
                dev->pio_mode = XFER_PIO_0;
+               dev->dma_mode = 0xff;
 
                /* If the controller has a pio mode setup function
                 * then use it to set the chipset to rights. Don't