]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
drivers/rtc: dump small buffers via %*ph
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Thu, 7 Feb 2013 01:27:41 +0000 (12:27 +1100)
committerStephen Rothwell <sfr@canb.auug.org.au>
Mon, 18 Feb 2013 05:47:13 +0000 (16:47 +1100)
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
drivers/rtc/rtc-ds1305.c
drivers/rtc/rtc-ds1307.c
drivers/rtc/rtc-fm3130.c

index d578773f5ce21c18f0660114ad72fe5afd646f9b..b05a6dc9640538d43966b2afdc7153dc241702c9 100644 (file)
@@ -635,9 +635,7 @@ static int ds1305_probe(struct spi_device *spi)
                goto fail0;
        }
 
-       dev_dbg(&spi->dev, "ctrl %s: %02x %02x %02x\n",
-                       "read", ds1305->ctrl[0],
-                       ds1305->ctrl[1], ds1305->ctrl[2]);
+       dev_dbg(&spi->dev, "ctrl %s: %3ph\n", "read", ds1305->ctrl);
 
        /* Sanity check register values ... partially compensating for the
         * fact that SPI has no device handshake.  A pullup on MISO would
@@ -723,9 +721,7 @@ static int ds1305_probe(struct spi_device *spi)
                        goto fail0;
                }
 
-               dev_dbg(&spi->dev, "ctrl %s: %02x %02x %02x\n",
-                               "write", ds1305->ctrl[0],
-                               ds1305->ctrl[1], ds1305->ctrl[2]);
+               dev_dbg(&spi->dev, "ctrl %s: %3ph\n", "write", ds1305->ctrl);
        }
 
        /* see if non-Linux software set up AM/PM mode */
index e0d0ba4de03f34d84b7454b7201050ee66e0317a..970a236b147a21ac76ad1b8cb86bf5039cfc1b5b 100644 (file)
@@ -322,12 +322,7 @@ static int ds1307_get_time(struct device *dev, struct rtc_time *t)
                return -EIO;
        }
 
-       dev_dbg(dev, "%s: %02x %02x %02x %02x %02x %02x %02x\n",
-                       "read",
-                       ds1307->regs[0], ds1307->regs[1],
-                       ds1307->regs[2], ds1307->regs[3],
-                       ds1307->regs[4], ds1307->regs[5],
-                       ds1307->regs[6]);
+       dev_dbg(dev, "%s: %7ph\n", "read", ds1307->regs);
 
        t->tm_sec = bcd2bin(ds1307->regs[DS1307_REG_SECS] & 0x7f);
        t->tm_min = bcd2bin(ds1307->regs[DS1307_REG_MIN] & 0x7f);
@@ -398,9 +393,7 @@ static int ds1307_set_time(struct device *dev, struct rtc_time *t)
                break;
        }
 
-       dev_dbg(dev, "%s: %02x %02x %02x %02x %02x %02x %02x\n",
-               "write", buf[0], buf[1], buf[2], buf[3],
-               buf[4], buf[5], buf[6]);
+       dev_dbg(dev, "%s: %7ph\n", "write", buf);
 
        result = ds1307->write_block_data(ds1307->client,
                ds1307->offset, 7, buf);
index 04e93c6597f8905b5cfeae366fc0e874f697973a..bff3cdc5140edd0c34350d3d84748c7a394d1844 100644 (file)
@@ -116,17 +116,7 @@ static int fm3130_get_time(struct device *dev, struct rtc_time *t)
 
        fm3130_rtc_mode(dev, FM3130_MODE_NORMAL);
 
-       dev_dbg(dev, "%s: %02x %02x %02x %02x %02x %02x %02x %02x"
-                       "%02x %02x %02x %02x %02x %02x %02x\n",
-                       "read",
-                       fm3130->regs[0], fm3130->regs[1],
-                       fm3130->regs[2], fm3130->regs[3],
-                       fm3130->regs[4], fm3130->regs[5],
-                       fm3130->regs[6], fm3130->regs[7],
-                       fm3130->regs[8], fm3130->regs[9],
-                       fm3130->regs[0xa], fm3130->regs[0xb],
-                       fm3130->regs[0xc], fm3130->regs[0xd],
-                       fm3130->regs[0xe]);
+       dev_dbg(dev, "%s: %15ph\n", "read", fm3130->regs);
 
        t->tm_sec = bcd2bin(fm3130->regs[FM3130_RTC_SECONDS] & 0x7f);
        t->tm_min = bcd2bin(fm3130->regs[FM3130_RTC_MINUTES] & 0x7f);
@@ -175,12 +165,7 @@ static int fm3130_set_time(struct device *dev, struct rtc_time *t)
        tmp = t->tm_year - 100;
        buf[FM3130_RTC_YEARS] = bin2bcd(tmp);
 
-       dev_dbg(dev, "%s: %02x %02x %02x %02x %02x %02x %02x"
-               "%02x %02x %02x %02x %02x %02x %02x %02x\n",
-               "write", buf[0], buf[1], buf[2], buf[3],
-               buf[4], buf[5], buf[6], buf[7],
-               buf[8], buf[9], buf[0xa], buf[0xb],
-               buf[0xc], buf[0xd], buf[0xe]);
+       dev_dbg(dev, "%s: %15ph\n", "write", buf);
 
        fm3130_rtc_mode(dev, FM3130_MODE_WRITE);
 
@@ -517,18 +502,8 @@ bad_alarm:
 bad_clock:
 
        if (!fm3130->data_valid || !fm3130->alarm_valid)
-               dev_dbg(&client->dev,
-                               "%s: %02x %02x %02x %02x %02x %02x %02x %02x"
-                               "%02x %02x %02x %02x %02x %02x %02x\n",
-                       "bogus registers",
-                       fm3130->regs[0], fm3130->regs[1],
-                       fm3130->regs[2], fm3130->regs[3],
-                       fm3130->regs[4], fm3130->regs[5],
-                       fm3130->regs[6], fm3130->regs[7],
-                       fm3130->regs[8], fm3130->regs[9],
-                       fm3130->regs[0xa], fm3130->regs[0xb],
-                       fm3130->regs[0xc], fm3130->regs[0xd],
-                       fm3130->regs[0xe]);
+               dev_dbg(&client->dev, "%s: %15ph\n", "bogus registers",
+                       fm3130->regs);
 
        /* We won't bail out here because we just got invalid data.
           Time setting from u-boot doesn't work anyway */