]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
Fix cx88 remote control input
authorLawrence Rust <lvr@softsystem.co.uk>
Fri, 8 Apr 2011 12:50:45 +0000 (09:50 -0300)
committerGreg Kroah-Hartman <gregkh@suse.de>
Sat, 21 May 2011 22:13:31 +0000 (15:13 -0700)
commit 2a164d02dd34c6b49a3f0995900e0f8af102b804 upstream.

In the IR interrupt handler of cx88-input.c there's a 32-bit multiply
overflow which causes IR pulse durations to be incorrectly calculated.

This is a regression caused by commit 2997137be8eba.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/media/video/cx88/cx88-input.c

index ac4f8e0750ef10b36b44dc264adcb4e12d868916..67a2b086101add040b25b7374817ce1779ef901e 100644 (file)
@@ -523,7 +523,7 @@ void cx88_ir_irq(struct cx88_core *core)
        for (todo = 32; todo > 0; todo -= bits) {
                ev.pulse = samples & 0x80000000 ? false : true;
                bits = min(todo, 32U - fls(ev.pulse ? samples : ~samples));
-               ev.duration = (bits * NSEC_PER_SEC) / (1000 * ir_samplerate);
+               ev.duration = (bits * (NSEC_PER_SEC / 1000)) / ir_samplerate;
                ir_raw_event_store_with_filter(ir->dev, &ev);
                samples <<= bits;
        }