staging: sm750fb: Refine the code and remove unused code.

Every call to the function waitNextVerticalSync() used the macro
primaryWaitVerticalSync(), so the macro was removed and the function
waitNextVerticalSync() renamed to primary_wait_vertical_sync().

With this change, an unnecessary 'if' statement was removed together
with the lines within the 'else' statement, because it was never
satisfied.

The modified function was refined to better match the Kernel coding
style.

Signed-off-by: Elise Lennion <elise.lennion@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/sm750fb/ddk750_display.c b/drivers/staging/sm750fb/ddk750_display.c
index aea97361d93756dea8e9858c6ef21a88ae23a948..0f3a875b0ef8c3d0bf776d6034efd9f57686dbb0 100644 (file)
--- a/drivers/staging/sm750fb/ddk750_display.c
+++ b/drivers/staging/sm750fb/ddk750_display.c
@@ -4,8 +4,6 @@
 #include "ddk750_power.h"
 #include "ddk750_dvi.h"
 
-#define primaryWaitVerticalSync(delay) waitNextVerticalSync(0, delay)
-
 static void setDisplayControl(int ctrl, int disp_state)
 {
        /* state != 0 means turn on both timing & plane en_bit */
@@ -61,55 +59,28 @@ static void setDisplayControl(int ctrl, int disp_state)
        }
 }
 
-static void waitNextVerticalSync(int ctrl, int delay)
+static void primary_wait_vertical_sync(int delay)
 {
        unsigned int status;
 
-       if (!ctrl) {
-               /* primary controller */
+       /*
+        * Do not wait when the Primary PLL is off or display control is
+        * already off. This will prevent the software to wait forever.
+        */
+       if (!(PEEK32(PANEL_PLL_CTRL) & PLL_CTRL_POWER) ||
+           !(PEEK32(PANEL_DISPLAY_CTRL) & DISPLAY_CTRL_TIMING))
+               return;
 
-               /*
-                * Do not wait when the Primary PLL is off or display control is
-                * already off. This will prevent the software to wait forever.
-                */
-               if (!(PEEK32(PANEL_PLL_CTRL) & PLL_CTRL_POWER) ||
-                   !(PEEK32(PANEL_DISPLAY_CTRL) & DISPLAY_CTRL_TIMING)) {
-                       return;
-               }
-
-               while (delay-- > 0) {
-                       /* Wait for end of vsync. */
-                       do {
-                               status = PEEK32(SYSTEM_CTRL);
-                       } while (status & SYSTEM_CTRL_PANEL_VSYNC_ACTIVE);
-
-                       /* Wait for start of vsync. */
-                       do {
-                               status = PEEK32(SYSTEM_CTRL);
-                       } while (!(status & SYSTEM_CTRL_PANEL_VSYNC_ACTIVE));
-               }
+       while (delay-- > 0) {
+               /* Wait for end of vsync. */
+               do {
+                       status = PEEK32(SYSTEM_CTRL);
+               } while (status & SYSTEM_CTRL_PANEL_VSYNC_ACTIVE);
 
-       } else {
-               /*
-                * Do not wait when the Primary PLL is off or display control is
-                * already off. This will prevent the software to wait forever.
-                */
-               if (!(PEEK32(CRT_PLL_CTRL) & PLL_CTRL_POWER) ||
-                   !(PEEK32(CRT_DISPLAY_CTRL) & DISPLAY_CTRL_TIMING)) {
-                       return;
-               }
-
-               while (delay-- > 0) {
-                       /* Wait for end of vsync. */
-                       do {
-                               status = PEEK32(SYSTEM_CTRL);
-                       } while (status & SYSTEM_CTRL_PANEL_VSYNC_ACTIVE);
-
-                       /* Wait for start of vsync. */
-                       do {
-                               status = PEEK32(SYSTEM_CTRL);
-                       } while (!(status & SYSTEM_CTRL_PANEL_VSYNC_ACTIVE));
-               }
+               /* Wait for start of vsync. */
+               do {
+                       status = PEEK32(SYSTEM_CTRL);
+               } while (!(status & SYSTEM_CTRL_PANEL_VSYNC_ACTIVE));
        }
 }
 
@@ -121,22 +92,22 @@ static void swPanelPowerSequence(int disp, int delay)
        reg = PEEK32(PANEL_DISPLAY_CTRL);
        reg |= (disp ? PANEL_DISPLAY_CTRL_FPEN : 0);
        POKE32(PANEL_DISPLAY_CTRL, reg);
-       primaryWaitVerticalSync(delay);
+       primary_wait_vertical_sync(delay);
 
        reg = PEEK32(PANEL_DISPLAY_CTRL);
        reg |= (disp ? PANEL_DISPLAY_CTRL_DATA : 0);
        POKE32(PANEL_DISPLAY_CTRL, reg);
-       primaryWaitVerticalSync(delay);
+       primary_wait_vertical_sync(delay);
 
        reg = PEEK32(PANEL_DISPLAY_CTRL);
        reg |= (disp ? PANEL_DISPLAY_CTRL_VBIASEN : 0);
        POKE32(PANEL_DISPLAY_CTRL, reg);
-       primaryWaitVerticalSync(delay);
+       primary_wait_vertical_sync(delay);
 
        reg = PEEK32(PANEL_DISPLAY_CTRL);
        reg |= (disp ? PANEL_DISPLAY_CTRL_FPEN : 0);
        POKE32(PANEL_DISPLAY_CTRL, reg);
-       primaryWaitVerticalSync(delay);
+       primary_wait_vertical_sync(delay);
 }
 
 void ddk750_setLogicalDispOut(disp_output_t output)