]> git.karo-electronics.de Git - linux-beck.git/commitdiff
spi: efm32: Don't call kfree() after spi_master_put()
authorAxel Lin <axel.lin@ingics.com>
Fri, 20 Sep 2013 10:39:18 +0000 (18:39 +0800)
committerMark Brown <broonie@linaro.org>
Mon, 23 Sep 2013 13:53:10 +0000 (14:53 +0100)
Calling kfree() to clean up the memory obtained from spi_alloc_master() is
wrong as this is done in spi_master_release() when spi_master->dev's refcount
reaches zero.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
drivers/spi/spi-efm32.c

index 7d84418a01d8c0fece0e4d6e73fbafe559f9b2e3..5b3117f69507171cadcd2169f89842627f147ec6 100644 (file)
@@ -467,7 +467,6 @@ err_disable_clk:
                clk_disable_unprepare(ddata->clk);
 err:
                spi_master_put(master);
-               kfree(master);
        }
 
        return ret;
@@ -484,7 +483,6 @@ static int efm32_spi_remove(struct platform_device *pdev)
        free_irq(ddata->rxirq, ddata);
        clk_disable_unprepare(ddata->clk);
        spi_master_put(master);
-       kfree(master);
 
        return 0;
 }