]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
NETFILTER: nfnetlink_log: fix computation of netlink skb size
authorEric Leblond <eric@inl.fr>
Mon, 17 Mar 2008 14:41:47 +0000 (15:41 +0100)
committerChris Wright <chrisw@sous-sol.org>
Mon, 24 Mar 2008 18:47:54 +0000 (11:47 -0700)
Upstream commit 7000d38d:

This patch is similar to nfnetlink_queue fixes. It fixes the computation
of skb size by using NLMSG_SPACE instead of NLMSG_ALIGN.

Signed-off-by: Eric Leblond <eric@inl.fr>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/netfilter/nfnetlink_log.c

index 2c7bd2eb0294400ed1175749f41281ed4f7b735b..dc43df193e051ca12a1b368aa437a92da2896c1d 100644 (file)
@@ -594,7 +594,7 @@ nfulnl_log_packet(unsigned int pf,
        /* FIXME: do we want to make the size calculation conditional based on
         * what is actually present?  way more branches and checks, but more
         * memory efficient... */
-       size =    NLMSG_ALIGN(sizeof(struct nfgenmsg))
+       size =    NLMSG_SPACE(sizeof(struct nfgenmsg))
                + nla_total_size(sizeof(struct nfulnl_msg_packet_hdr))
                + nla_total_size(sizeof(u_int32_t))     /* ifindex */
                + nla_total_size(sizeof(u_int32_t))     /* ifindex */