]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
bdi: fix wrong error return value in cgwb_create()
authorTejun Heo <tj@kernel.org>
Thu, 4 Jun 2015 21:20:51 +0000 (06:20 +0900)
committerJens Axboe <axboe@fb.com>
Thu, 4 Jun 2015 21:21:43 +0000 (15:21 -0600)
On wb_congested_get_create() failure, cgwb_create() forgot to set @ret
to -ENOMEM ending up returning 0.  Fix it so that it returns -ENOMEM.

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
mm/backing-dev.c

index 887d72a85b5e1af6fbc897503dfe72f8c4a21951..436bb53dd383f24380b11a44d6f3e39c42c39fbb 100644 (file)
@@ -554,8 +554,10 @@ static int cgwb_create(struct backing_dev_info *bdi,
                goto err_ref_exit;
 
        wb->congested = wb_congested_get_create(bdi, blkcg_css->id, gfp);
-       if (!wb->congested)
+       if (!wb->congested) {
+               ret = -ENOMEM;
                goto err_fprop_exit;
+       }
 
        wb->memcg_css = memcg_css;
        wb->blkcg_css = blkcg_css;