]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
drm/vc4: Fix NULL deref in HDMI init error path
authorEric Anholt <eric@anholt.net>
Mon, 4 Apr 2016 21:25:59 +0000 (14:25 -0700)
committerEric Anholt <eric@anholt.net>
Thu, 14 Apr 2016 19:23:11 +0000 (12:23 -0700)
If you make it here other than through err_destroy_encoder, vc4->hdmi
is still NULL.

Signed-off-by: Eric Anholt <eric@anholt.net>
drivers/gpu/drm/vc4/vc4_hdmi.c

index d8b864925fd38757cdc12e72d5ea102f32d2af09..fd2644d231ff867a4409840eba7f8234a4a1faba 100644 (file)
@@ -573,7 +573,7 @@ err_unprepare_hsm:
 err_unprepare_pix:
        clk_disable_unprepare(hdmi->pixel_clock);
 err_put_i2c:
-       put_device(&vc4->hdmi->ddc->dev);
+       put_device(&hdmi->ddc->dev);
 
        return ret;
 }