]> git.karo-electronics.de Git - linux-beck.git/commitdiff
vme: fake: mark symbols static where possible
authorBaoyou Xie <baoyou.xie@linaro.org>
Fri, 23 Sep 2016 13:38:28 +0000 (21:38 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 27 Sep 2016 10:43:34 +0000 (12:43 +0200)
We get 4 warnings when building kernel with W=1:
drivers/vme/bridges/vme_fake.c:384:6: warning: no previous prototype for 'fake_lm_check' [-Wmissing-prototypes]
drivers/vme/bridges/vme_fake.c:619:6: warning: no previous prototype for 'fake_vmewrite8' [-Wmissing-prototypes]
drivers/vme/bridges/vme_fake.c:649:6: warning: no previous prototype for 'fake_vmewrite16' [-Wmissing-prototypes]
drivers/vme/bridges/vme_fake.c:679:6: warning: no previous prototype for 'fake_vmewrite32' [-Wmissing-prototypes]

In fact, these functions are only used in the file in which they are
declared and don't need a declaration, but can be made static.
so this patch marks these functions with 'static'.

Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
Acked-by: Martyn Welch <martyn@welchs.me.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/vme/bridges/vme_fake.c

index ebf35d3053217af539173560f62c9c02ef42abbc..29ac74f7889d1ec05d3edbfca5b48cdedd808914 100644 (file)
@@ -381,8 +381,8 @@ static int fake_master_get(struct vme_master_resource *image, int *enabled,
 }
 
 
-void fake_lm_check(struct fake_driver *bridge, unsigned long long addr,
-               u32 aspace, u32 cycle)
+static void fake_lm_check(struct fake_driver *bridge, unsigned long long addr,
+                         u32 aspace, u32 cycle)
 {
        struct vme_bridge *fake_bridge;
        unsigned long long lm_base;
@@ -616,8 +616,8 @@ out:
        return retval;
 }
 
-void fake_vmewrite8(struct fake_driver *bridge, u8 *buf,
-                unsigned long long addr, u32 aspace, u32 cycle)
+static void fake_vmewrite8(struct fake_driver *bridge, u8 *buf,
+                          unsigned long long addr, u32 aspace, u32 cycle)
 {
        int i;
        unsigned long long start, end, offset;
@@ -646,8 +646,8 @@ void fake_vmewrite8(struct fake_driver *bridge, u8 *buf,
 
 }
 
-void fake_vmewrite16(struct fake_driver *bridge, u16 *buf,
-               unsigned long long addr, u32 aspace, u32 cycle)
+static void fake_vmewrite16(struct fake_driver *bridge, u16 *buf,
+                           unsigned long long addr, u32 aspace, u32 cycle)
 {
        int i;
        unsigned long long start, end, offset;
@@ -676,8 +676,8 @@ void fake_vmewrite16(struct fake_driver *bridge, u16 *buf,
 
 }
 
-void fake_vmewrite32(struct fake_driver *bridge, u32 *buf,
-               unsigned long long addr, u32 aspace, u32 cycle)
+static void fake_vmewrite32(struct fake_driver *bridge, u32 *buf,
+                           unsigned long long addr, u32 aspace, u32 cycle)
 {
        int i;
        unsigned long long start, end, offset;