]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
hwmon: (ds1621) fix coccinelle warnings
authorFengguang Wu <fengguang.wu@intel.com>
Wed, 18 Sep 2013 03:54:09 +0000 (20:54 -0700)
committerGuenter Roeck <linux@roeck-us.net>
Sun, 13 Oct 2013 23:16:30 +0000 (16:16 -0700)
drivers/hwmon/ds1621.c:381:1-3: WARNING: PTR_RET can be used

 Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: coccinelle/api/ptr_ret.cocci

CC: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/ds1621.c

index 5e398c98db2eddde3bbff8957602a5c9f120c5b9..872d76744e30d1a7d603cc6ca332ab2aa76a965f 100644 (file)
@@ -378,10 +378,7 @@ static int ds1621_probe(struct i2c_client *client,
        hwmon_dev = devm_hwmon_device_register_with_groups(&client->dev,
                                                           client->name, data,
                                                           ds1621_groups);
-       if (IS_ERR(hwmon_dev))
-               return PTR_ERR(hwmon_dev);
-
-       return 0;
+       return PTR_ERR_OR_ZERO(hwmon_dev);
 }
 
 static const struct i2c_device_id ds1621_id[] = {