]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
qed: Fix setting/clearing bit in completion bitmap
authorManish Chopra <manish.chopra@qlogic.com>
Mon, 25 Jul 2016 16:07:46 +0000 (19:07 +0300)
committerDavid S. Miller <davem@davemloft.net>
Tue, 26 Jul 2016 04:41:19 +0000 (21:41 -0700)
Slowpath completion handling is incorrectly changing
SPQ_RING_SIZE bits instead of a single one.

Fixes: 76a9a3642a0b ("qed: fix handling of concurrent ramrods")
Signed-off-by: Manish Chopra <manish.chopra@qlogic.com>
Signed-off-by: Yuval Mintz <Yuval.Mintz@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qed/qed_spq.c

index 97ffeae262bb36519a76f2ac9e8c152b324ae3a8..d73456eab1d7e660a5a6ce404c3ceb00465fa62f 100644 (file)
@@ -815,13 +815,12 @@ int qed_spq_completion(struct qed_hwfn *p_hwfn,
                         * in a bitmap and increasing the chain consumer only
                         * for the first successive completed entries.
                         */
-                       bitmap_set(p_spq->p_comp_bitmap, pos, SPQ_RING_SIZE);
+                       __set_bit(pos, p_spq->p_comp_bitmap);
 
                        while (test_bit(p_spq->comp_bitmap_idx,
                                        p_spq->p_comp_bitmap)) {
-                               bitmap_clear(p_spq->p_comp_bitmap,
-                                            p_spq->comp_bitmap_idx,
-                                            SPQ_RING_SIZE);
+                               __clear_bit(p_spq->comp_bitmap_idx,
+                                           p_spq->p_comp_bitmap);
                                p_spq->comp_bitmap_idx++;
                                qed_chain_return_produced(&p_spq->chain);
                        }