]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
hwmon: (sht15) fix bad error code
authorVivien Didelot <vivien.didelot@savoirfairelinux.com>
Thu, 26 Jan 2012 20:59:00 +0000 (15:59 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 3 Feb 2012 17:26:58 +0000 (09:26 -0800)
commit 6edf3c30af01854c416f8654d3d5d2652470afd4 upstream.

When no platform data was supplied, returned error code was 0.

Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hwmon/sht15.c

index 204050720efb256a7446080ea4594fe6add47140..740785e650bdc5313e4b2d7c2cf7b5dd34d6eb66 100644 (file)
@@ -515,7 +515,7 @@ static int sht15_invalidate_voltage(struct notifier_block *nb,
 
 static int __devinit sht15_probe(struct platform_device *pdev)
 {
-       int ret = 0;
+       int ret;
        struct sht15_data *data = kzalloc(sizeof(*data), GFP_KERNEL);
 
        if (!data) {
@@ -532,6 +532,7 @@ static int __devinit sht15_probe(struct platform_device *pdev)
        init_waitqueue_head(&data->wait_queue);
 
        if (pdev->dev.platform_data == NULL) {
+               ret = -EINVAL;
                dev_err(&pdev->dev, "no platform data supplied");
                goto err_free_data;
        }