]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
b43legacy: Fix error due to MMIO access with SSB unpowered
authorLarry Finger <Larry.Finger@lwfinger.net>
Sun, 6 May 2012 21:01:05 +0000 (16:01 -0500)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 30 May 2012 23:43:59 +0000 (00:43 +0100)
commit 8f4b20388fa77226a3605627a33a23f90d559e50 upstream.

There is a dummy read of a PCI MMIO register that occurs before the SSB bus
has been powered, which is an error. This bug has not been seen earlier,
but was apparently exposed when udev was updated to version 182.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/net/wireless/b43legacy/main.c

index 20f02437af8c73c4416987112abd6c75a91bc301..c5ce163e53d7f0cc47945fd989030d30692ab2d8 100644 (file)
@@ -1564,8 +1564,6 @@ static int b43legacy_request_firmware(struct b43legacy_wldev *dev)
        const char *filename;
        int err;
 
-       /* do dummy read */
-       ssb_read32(dev->dev, SSB_TMSHIGH);
        if (!fw->ucode) {
                if (rev == 2)
                        filename = "ucode2";