]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
tracing: fix ref count in splice pages
authorSteven Rostedt <srostedt@redhat.com>
Wed, 29 Apr 2009 04:16:21 +0000 (00:16 -0400)
committerSteven Rostedt <rostedt@goodmis.org>
Wed, 29 Apr 2009 04:16:21 +0000 (00:16 -0400)
The pages allocated for the splice binary buffer did not initialize
the ref count correctly. This caused pages not to be freed and causes
a drastic memory leak.

Thanks to logdev I was able to trace the tracer to find where the leak
was.

[ Impact: stop memory leak when using splice ]

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
kernel/trace/trace.c

index 5d704a41f836643741002cb6a81037017063b269..9058240c85ca4faa525f7121abec47a43022d03b 100644 (file)
@@ -3531,6 +3531,7 @@ tracing_buffers_splice_read(struct file *file, loff_t *ppos,
                if (!ref)
                        break;
 
+               ref->ref = 1;
                ref->buffer = info->tr->buffer;
                ref->page = ring_buffer_alloc_read_page(ref->buffer);
                if (!ref->page) {