]> git.karo-electronics.de Git - linux-beck.git/commitdiff
drivers/hid/hid-lg4ff.c: avoid world-writable sysfs files.
authorRusty Russell <rusty@rustcorp.com.au>
Wed, 14 May 2014 01:03:48 +0000 (10:33 +0930)
committerRusty Russell <rusty@rustcorp.com.au>
Wed, 14 May 2014 01:23:54 +0000 (10:53 +0930)
In line with practice for module parameters, we're adding a build-time
check that sysfs files aren't world-writable.

Cc: Simon Wood <simon@mungewell.org>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
drivers/hid/hid-lg4ff.c

index 24883b4d1a49d40a2bb3462ee36ed094f474b3cd..cc2bd20221989aa0284269cce533c28ab2e7295c 100644 (file)
@@ -52,7 +52,7 @@ static void hid_lg4ff_set_range_g25(struct hid_device *hid, u16 range);
 static ssize_t lg4ff_range_show(struct device *dev, struct device_attribute *attr, char *buf);
 static ssize_t lg4ff_range_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t count);
 
-static DEVICE_ATTR(range, S_IRWXU | S_IRWXG | S_IRWXO, lg4ff_range_show, lg4ff_range_store);
+static DEVICE_ATTR(range, S_IRWXU | S_IRWXG | S_IROTH, lg4ff_range_show, lg4ff_range_store);
 
 struct lg4ff_device_entry {
        __u32 product_id;