]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
Staging: rtl8712: Remove zero-testing pointer typed value
authorAmitoj Kaur Chawla <amitoj1606@gmail.com>
Tue, 31 Mar 2015 19:22:18 +0000 (00:52 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 1 Apr 2015 15:26:58 +0000 (17:26 +0200)
Removes variable comparison with 0 by using !. Done using following
coccinelle script.

@ disable is_zero,isnt_zero @
expression *E;
expression E1,f;
@@

E = f(...)
<...
(
- E == 0
+ !E
|
- E != 0
+ E
|
- 0 == E
+ !E
|
- 0 != E
+ E
)
...>
?E = E1

@ disable is_zero,isnt_zero @
expression *E;
@@

(
  E ==
- 0
+ NULL
|
  E !=
- 0
+ NULL
|
- 0
+ NULL
  == E
|
- 0
+ NULL
  != E
)

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8712/rtl871x_security.c

index a178c232b44a447be77fd2d061df306730286336..bcd1a51288689d1043d069b3d96829baa87b8408 100644 (file)
@@ -153,7 +153,7 @@ static u32 getcrc32(u8 *buf, u32 len)
        u8 *p;
        u32  crc;
 
-       if (bcrc32initialized == 0)
+       if (!bcrc32initialized)
                crc32_init();
        crc = 0xffffffff; /* preload shift register, per CRC-32 spec */
        for (p = buf; len > 0; ++p, --len)