]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
staging: lustre: lmv: access lum_stripe_offset as little endian
authorJohn L. Hammond <john.hammond@intel.com>
Tue, 16 Aug 2016 20:18:41 +0000 (16:18 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 21 Aug 2016 13:57:35 +0000 (15:57 +0200)
By the time that a struct lmv_user_md reaches lmv_placement_policy()
it has already been converted to little endian. Therefore use the
appropriate macros around accesses to this this field. This issue was
found by rewriting the definition of struct lmv_user_md to use the
__leXX typedefs and running sparse.

Signed-off-by: John L. Hammond <john.hammond@intel.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4738
Reviewed-on: http://review.whamcloud.com/9671
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: Swapnil Pimpale <spimpale@ddn.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/lustre/lustre/lmv/lmv_obd.c

index c005a66e06e7d408f88695b7d5831348c4c78541..59299949c7f44463353b0128260c24bed1124ab7 100644 (file)
@@ -1242,15 +1242,15 @@ static int lmv_placement_policy(struct obd_device *obd,
                struct lmv_user_md *lum;
 
                lum = op_data->op_data;
-               if (lum->lum_stripe_offset != (__u32)-1) {
-                       *mds = lum->lum_stripe_offset;
+               if (le32_to_cpu(lum->lum_stripe_offset) != (__u32)-1) {
+                       *mds = le32_to_cpu(lum->lum_stripe_offset);
                } else {
                        /*
                         * -1 means default, which will be in the same MDT with
                         * the stripe
                         */
                        *mds = op_data->op_mds;
-                       lum->lum_stripe_offset = op_data->op_mds;
+                       lum->lum_stripe_offset = cpu_to_le32(op_data->op_mds);
                }
        } else {
                /*