]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
mm-page_alloc-refactor-out-__alloc_contig_migrate_alloc-checkpatch-fixes
authorAndrew Morton <akpm@linux-foundation.org>
Fri, 28 Sep 2012 00:19:50 +0000 (10:19 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Tue, 9 Oct 2012 03:12:35 +0000 (14:12 +1100)
ERROR: code indent should use tabs where possible
#73: FILE: mm/page_isolation.c:253:
+                             int **resultp)$

WARNING: please, no spaces at the start of a line
#73: FILE: mm/page_isolation.c:253:
+                             int **resultp)$

ERROR: code indent should use tabs where possible
#75: FILE: mm/page_isolation.c:255:
+        gfp_t gfp_mask = GFP_USER | __GFP_MOVABLE;$

WARNING: please, no spaces at the start of a line
#75: FILE: mm/page_isolation.c:255:
+        gfp_t gfp_mask = GFP_USER | __GFP_MOVABLE;$

ERROR: code indent should use tabs where possible
#77: FILE: mm/page_isolation.c:257:
+        if (PageHighMem(page))$

WARNING: please, no spaces at the start of a line
#77: FILE: mm/page_isolation.c:257:
+        if (PageHighMem(page))$

ERROR: code indent should use tabs where possible
#78: FILE: mm/page_isolation.c:258:
+                gfp_mask |= __GFP_HIGHMEM;$

WARNING: please, no spaces at the start of a line
#78: FILE: mm/page_isolation.c:258:
+                gfp_mask |= __GFP_HIGHMEM;$

ERROR: code indent should use tabs where possible
#80: FILE: mm/page_isolation.c:260:
+        return alloc_page(gfp_mask);$

WARNING: please, no spaces at the start of a line
#80: FILE: mm/page_isolation.c:260:
+        return alloc_page(gfp_mask);$

total: 5 errors, 5 warnings, 48 lines checked

NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
      scripts/cleanfile

./patches/mm-page_alloc-refactor-out-__alloc_contig_migrate_alloc.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Minchan Kim <minchan@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/page_isolation.c

index 5225799eb20496c04df9b0ff216cffaa3ea44d2e..f2f5b4818e948bd1436cc730757f6c90749885ef 100644 (file)
@@ -257,12 +257,12 @@ int test_pages_isolated(unsigned long start_pfn, unsigned long end_pfn)
 }
 
 struct page *alloc_migrate_target(struct page *page, unsigned long private,
-                             int **resultp)
+                                 int **resultp)
 {
-        gfp_t gfp_mask = GFP_USER | __GFP_MOVABLE;
+       gfp_t gfp_mask = GFP_USER | __GFP_MOVABLE;
 
-        if (PageHighMem(page))
-                gfp_mask |= __GFP_HIGHMEM;
+       if (PageHighMem(page))
+               gfp_mask |= __GFP_HIGHMEM;
 
-        return alloc_page(gfp_mask);
+       return alloc_page(gfp_mask);
 }