]> git.karo-electronics.de Git - linux-beck.git/commitdiff
serial: 8250_dma: power off device after TX is done
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 14 Nov 2016 10:26:52 +0000 (12:26 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 16 Nov 2016 09:57:26 +0000 (10:57 +0100)
When any 8250 based driver sets up DMA and has UART_CAP_RPM capability enabled
the device is left powered on after transfer is done. We need to schedule a
device suspend operation when DMA completes the transfer.

The patch is based on the work done by the reporter.

Reported-by: Huiquan Zhong <huiquan.zhong@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_dma.c

index fdbddbc6375da50932d3ce156d4bc2643de67b20..26f17456b0d76143484b46ff3e948ee55e79b3eb 100644 (file)
@@ -72,10 +72,15 @@ int serial8250_tx_dma(struct uart_8250_port *p)
        struct dma_async_tx_descriptor  *desc;
        int ret;
 
-       if (uart_tx_stopped(&p->port) || dma->tx_running ||
-           uart_circ_empty(xmit))
+       if (dma->tx_running)
                return 0;
 
+       if (uart_tx_stopped(&p->port) || uart_circ_empty(xmit)) {
+               /* We have been called from __dma_tx_complete() */
+               serial8250_rpm_put_tx(p);
+               return 0;
+       }
+
        dma->tx_size = CIRC_CNT_TO_END(xmit->head, xmit->tail, UART_XMIT_SIZE);
 
        desc = dmaengine_prep_slave_single(dma->txchan,