]> git.karo-electronics.de Git - linux-beck.git/commitdiff
staging: wilc1000: fixes potential null dereference 'wid.val'
authorLeo Kim <leo.kim@atmel.com>
Mon, 21 Dec 2015 05:18:24 +0000 (14:18 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 21 Dec 2015 21:20:04 +0000 (13:20 -0800)
This patch fixes the error reported by smatch.
 - Handle_ListenStateExpired() error: potential null dereference 'wid.val'
If kmalloc failed, referenced to a NULL pointer.

Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wilc1000/host_interface.c

index d1707f6f0dccd45b5c3051aaa3e79b438d2c3059..2289ba34430070524c8ce7b1bdcb158fdfe5c614 100644 (file)
@@ -2635,8 +2635,10 @@ static u32 Handle_ListenStateExpired(struct host_if_drv *hif_drv,
                wid.size = 2;
                wid.val = kmalloc(wid.size, GFP_KERNEL);
 
-               if (!wid.val)
+               if (!wid.val) {
                        PRINT_ER("Failed to allocate memory\n");
+                       return -ENOMEM;
+               }
 
                wid.val[0] = u8remain_on_chan_flag;
                wid.val[1] = FALSE_FRMWR_CHANNEL;