]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
hwmon/f71882fg: Set platform drvdata to NULL later
authorHans de Goede <hdegoede@redhat.com>
Sun, 13 Mar 2011 12:50:33 +0000 (13:50 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Wed, 23 Mar 2011 20:16:36 +0000 (13:16 -0700)
commit d9ebaa45472c92704f4814682eec21455edcfa1f upstream.

This avoids a possible race leading to trying to dereference NULL.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/hwmon/f71882fg.c

index 4146105f1a5779a5de55006444b9de99e90e8319..efbb602210440d4594bf860cbbaecb1da5b8cafc 100644 (file)
@@ -1957,7 +1957,6 @@ static int f71882fg_remove(struct platform_device *pdev)
        int i;
        struct f71882fg_data *data = platform_get_drvdata(pdev);
 
-       platform_set_drvdata(pdev, NULL);
        if (data->hwmon_dev)
                hwmon_device_unregister(data->hwmon_dev);
 
@@ -1982,6 +1981,7 @@ static int f71882fg_remove(struct platform_device *pdev)
        for (i = 0; i < ARRAY_SIZE(f8000_fan_attr); i++)
                device_remove_file(&pdev->dev, &f8000_fan_attr[i].dev_attr);
 
+       platform_set_drvdata(pdev, NULL);
        kfree(data);
 
        return 0;