]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
staging: comedi: dmm32at: remove unnecessary printk noise
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Tue, 26 Nov 2013 23:41:44 +0000 (16:41 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 3 Dec 2013 17:20:20 +0000 (09:20 -0800)
A timeout will return -ETIMEDOUT. The printks are just added noise.
Remove them.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/dmm32at.c

index bd192de319d36b46c7496a682892f86191c8e932..f057d7995bad0da34d76077c7bc97d5b7bfda0fb 100644 (file)
@@ -199,10 +199,8 @@ static int dmm32at_ai_rinsn(struct comedi_device *dev,
                if ((status & DMM32AT_STATUS) == 0)
                        break;
        }
-       if (i == 40000) {
-               printk(KERN_WARNING "dmm32at: timeout\n");
+       if (i == 40000)
                return -ETIMEDOUT;
-       }
 
        /* convert n samples */
        for (n = 0; n < insn->n; n++) {
@@ -214,10 +212,8 @@ static int dmm32at_ai_rinsn(struct comedi_device *dev,
                        if ((status & DMM32AT_STATUS) == 0)
                                break;
                }
-               if (i == 40000) {
-                       printk(KERN_WARNING "dmm32at: timeout\n");
+               if (i == 40000)
                        return -ETIMEDOUT;
-               }
 
                /* read data */
                lsb = inb(dev->iobase + DMM32AT_AILSB);
@@ -453,10 +449,8 @@ static int dmm32at_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
                if ((status & DMM32AT_STATUS) == 0)
                        break;
        }
-       if (i == 40000) {
-               printk(KERN_WARNING "dmm32at: timeout\n");
+       if (i == 40000)
                return -ETIMEDOUT;
-       }
 
        if (devpriv->ai_scans_left > 1) {
                /* start the clock and enable the interrupts */
@@ -567,10 +561,9 @@ static int dmm32at_ao_winsn(struct comedi_device *dev,
                        if ((status & DMM32AT_DACBUSY) == 0)
                                break;
                }
-               if (i == 40000) {
-                       printk(KERN_WARNING "dmm32at: timeout\n");
+               if (i == 40000)
                        return -ETIMEDOUT;
-               }
+
                /* dummy read to update trigger the output */
                status = inb(dev->iobase + DMM32AT_DACMSB);