]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
ARM: zynq: Set bit 22 in PL310 AuxCtrl register (6395/1)
authorThomas Betker <thomas.betker@rohde-schwarz.com>
Tue, 12 May 2015 06:22:01 +0000 (08:22 +0200)
committerMichal Simek <michal.simek@xilinx.com>
Wed, 22 Jul 2015 07:37:58 +0000 (09:37 +0200)
This patch is based on the
commit 1a8e41cd672f ("ARM: 6395/1: VExpress: Set bit 22 in the PL310
(cache controller) AuxCtlr register")

Clearing bit 22 in the PL310 Auxiliary Control register (shared
attribute override enable) has the side effect of transforming Normal
Shared Non-cacheable reads into Cacheable no-allocate reads.

Coherent DMA buffers in Linux always have a cacheable alias via the
kernel linear mapping and the processor can speculatively load cache
lines into the PL310 controller. With bit 22 cleared, Non-cacheable
reads would unexpectedly hit such cache lines leading to buffer
corruption.

For Zynq, this fix avoids memory inconsistencies between Gigabit
Ethernet controller (GEM) and CPU when DMA_CMA is disabled.

Suggested-by: Punnaiah Choudary Kalluri <punnaia@xilinx.com>
Signed-off-by: Thomas Betker <thomas.betker@rohde-schwarz.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
arch/arm/mach-zynq/common.c

index 616d5840fc2e4aefe2af918a56aa48a85f3c931c..6bd4a43e1a7835fecd005e09808de61cece7cdd0 100644 (file)
@@ -197,8 +197,8 @@ static const char * const zynq_dt_match[] = {
 
 DT_MACHINE_START(XILINX_EP107, "Xilinx Zynq Platform")
        /* 64KB way size, 8-way associativity, parity disabled */
-       .l2c_aux_val    = 0x00000000,
-       .l2c_aux_mask   = 0xffffffff,
+       .l2c_aux_val    = 0x00400000,
+       .l2c_aux_mask   = 0xffbfffff,
        .smp            = smp_ops(zynq_smp_ops),
        .map_io         = zynq_map_io,
        .init_irq       = zynq_irq_init,