]> git.karo-electronics.de Git - linux-beck.git/commitdiff
iommu/vt-d: Propagate error-value from ir_parse_ioapic_hpet_scope()
authorJoerg Roedel <jroedel@suse.de>
Fri, 23 Oct 2015 09:57:13 +0000 (11:57 +0200)
committerJoerg Roedel <jroedel@suse.de>
Fri, 23 Oct 2015 10:00:54 +0000 (12:00 +0200)
Propagate the error-value from the function ir_parse_ioapic_hpet_scope()
in parse_ioapics_under_ir() and cleanup its calling loop.

Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/intel_irq_remapping.c

index 7843252afda87d29d9de1f8993e013a9638e9c09..f3a9bd1bea43b398b86cca6929dca07ba2e7e77d 100644 (file)
@@ -934,13 +934,18 @@ static int __init parse_ioapics_under_ir(void)
        bool ir_supported = false;
        int ioapic_idx;
 
-       for_each_iommu(iommu, drhd)
-               if (ecap_ir_support(iommu->ecap)) {
-                       if (ir_parse_ioapic_hpet_scope(drhd->hdr, iommu))
-                               return -1;
+       for_each_iommu(iommu, drhd) {
+               int ret;
 
-                       ir_supported = true;
-               }
+               if (!ecap_ir_support(iommu->ecap))
+                       continue;
+
+               ret = ir_parse_ioapic_hpet_scope(drhd->hdr, iommu);
+               if (ret)
+                       return ret;
+
+               ir_supported = true;
+       }
 
        if (!ir_supported)
                return -ENODEV;