]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
virtio-net: remove useless disable on freeze
authorMichael S. Tsirkin <mst@redhat.com>
Wed, 4 Apr 2012 09:14:34 +0000 (12:14 +0300)
committerMichael S. Tsirkin <mst@redhat.com>
Wed, 18 Apr 2012 18:34:04 +0000 (21:34 +0300)
disable_cb is just an optimization: it
can not guarantee that there are no callbacks.

I didn't yet figure out whether a callback
in freeze will trigger a bug, but disable_cb
won't address it in any case. So let's remove
the useless calls as a first step.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
drivers/net/virtio_net.c

index 4de2760c593762634f0925cf9ccb1ab9c7f2c111..3e4767f0656cba27f47712b3b02749e9efc2a50e 100644 (file)
@@ -1183,11 +1183,6 @@ static int virtnet_freeze(struct virtio_device *vdev)
 {
        struct virtnet_info *vi = vdev->priv;
 
-       virtqueue_disable_cb(vi->rvq);
-       virtqueue_disable_cb(vi->svq);
-       if (virtio_has_feature(vi->vdev, VIRTIO_NET_F_CTRL_VQ))
-               virtqueue_disable_cb(vi->cvq);
-
        netif_device_detach(vi->dev);
        cancel_delayed_work_sync(&vi->refill);