]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
[media] coda: remove redundant call to v4l2_m2m_get_vq
authorColin Ian King <colin.king@canonical.com>
Thu, 23 Mar 2017 11:57:46 +0000 (08:57 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Mon, 10 Apr 2017 17:38:40 +0000 (14:38 -0300)
The call to v4ls_m2m_get_vq is only used to get the return value
which is not being used, so it appears to be redundant and can
be removed.

Detected with CoverityScan, CID#1420674 ("Useless call")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/platform/coda/coda-common.c

index 800d2477f1a015ef3874a3da0105148a57bc64d3..95e4648f18e6bb85af274779dd7c27953d857daa 100644 (file)
@@ -817,8 +817,6 @@ static int coda_qbuf(struct file *file, void *priv,
 static bool coda_buf_is_end_of_stream(struct coda_ctx *ctx,
                                      struct vb2_v4l2_buffer *buf)
 {
-       v4l2_m2m_get_vq(ctx->fh.m2m_ctx, V4L2_BUF_TYPE_VIDEO_OUTPUT);
-
        return ((ctx->bit_stream_param & CODA_BIT_STREAM_END_FLAG) &&
                (buf->sequence == (ctx->qsequence - 1)));
 }