]> git.karo-electronics.de Git - linux-beck.git/commitdiff
perf tests: Use lower sample_freq in sw clock event period test
authorArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 11 Nov 2013 19:33:18 +0000 (16:33 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 11 Nov 2013 19:43:34 +0000 (16:43 -0300)
We were using it at 10 kHz, which doesn't work in machines where somehow
the max freq was auto reduced by the kernel:

[root@ssdandy ~]# perf test 19
19: Test software clock events have valid period values    : FAILED!
[root@ssdandy ~]# perf test -v 19
19: Test software clock events have valid period values    :
--- start ---
Couldn't open evlist: Invalid argument
---- end ----
Test software clock events have valid period values: FAILED!
[root@ssdandy ~]#

[root@ssdandy ~]# cat /proc/sys/kernel/perf_event_max_sample_rate
7000

Reducing it to 500 Hz should be good enough for this test and also
shouldn't affect what it is testing.

But warn the user if it fails, informing the knob and the freq tried.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-548rhj1uo6xbwnxa95kw3hqe@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/tests/sw-clock.c

index ed777728dfe74043dc3e9398acdde3dcaa0da3da..93a7139ff5f79ef7fe41601ce7050f15efc2325f 100644 (file)
@@ -34,7 +34,7 @@ static int __test__sw_clock_freq(enum perf_sw_ids clock_id)
                .freq = 1,
        };
 
-       attr.sample_freq = 10000;
+       attr.sample_freq = 500;
 
        evlist = perf_evlist__new();
        if (evlist == NULL) {
@@ -58,8 +58,11 @@ static int __test__sw_clock_freq(enum perf_sw_ids clock_id)
        }
 
        if (perf_evlist__open(evlist)) {
+               const char *knob = "/proc/sys/kernel/perf_event_max_sample_rate";
+
                err = -errno;
-               pr_debug("Couldn't open evlist: %s\n", strerror(errno));
+               pr_debug("Couldn't open evlist: %s\nHint: check %s, using %" PRIu64 " in this test.\n",
+                        strerror(errno), knob, (u64)attr.sample_freq);
                goto out_delete_maps;
        }