]> git.karo-electronics.de Git - linux-beck.git/commitdiff
greybus: bootrom: Rename download_firmware() as find_firmware()
authorViresh Kumar <viresh.kumar@linaro.org>
Fri, 22 Jul 2016 21:13:44 +0000 (14:13 -0700)
committerGreg Kroah-Hartman <gregkh@google.com>
Fri, 22 Jul 2016 22:25:18 +0000 (15:25 -0700)
The download_firmware() function isn't downloading the firmware but just
finding if one is available or not. The same applies to the error
message printed by it.

Replace 'download' with 'find' to make it sound better.

Reported-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
drivers/staging/greybus/bootrom.c

index b90b25cadf5d0813f2cedda90989e27a6f54787c..e7cfa80b6b0b458724cb74c94bc70110843a16a8 100644 (file)
@@ -140,7 +140,7 @@ static void bootrom_es2_fixup_vid_pid(struct gb_bootrom *bootrom)
 }
 
 /* This returns path of the firmware blob on the disk */
-static int download_firmware(struct gb_bootrom *bootrom, u8 stage)
+static int find_firmware(struct gb_bootrom *bootrom, u8 stage)
 {
        struct gb_connection *connection = bootrom->connection;
        struct gb_interface *intf = connection->bundle->intf;
@@ -177,8 +177,8 @@ static int download_firmware(struct gb_bootrom *bootrom, u8 stage)
        rc = request_firmware(&bootrom->fw, firmware_name,
                &connection->bundle->dev);
        if (rc) {
-               dev_err(&connection->bundle->dev, "failed to download %s firmware (%d)\n",
-                       firmware_name, rc);
+               dev_err(&connection->bundle->dev,
+                       "failed to find %s firmware (%d)\n", firmware_name, rc);
        }
 
        return rc;
@@ -205,7 +205,7 @@ static int gb_bootrom_firmware_size_request(struct gb_operation *op)
 
        mutex_lock(&bootrom->mutex);
 
-       ret = download_firmware(bootrom, size_request->stage);
+       ret = find_firmware(bootrom, size_request->stage);
        if (ret)
                goto unlock;