]> git.karo-electronics.de Git - linux-beck.git/commitdiff
[media] mn88472: Deletion of an unnecessary check before the function call "release_f...
authorMarkus Elfring <elfring@users.sourceforge.net>
Sun, 1 Feb 2015 18:12:56 +0000 (15:12 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Wed, 1 Apr 2015 09:22:27 +0000 (06:22 -0300)
The release_firmware() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/staging/media/mn88472/mn88472.c

index 6eebe564e5573e6187d30777f247f084f8421eba..ce14cb287594a062b3ee3909ece84bc3d044bd09 100644 (file)
@@ -299,8 +299,7 @@ static int mn88472_init(struct dvb_frontend *fe)
 
        return 0;
 err:
-       if (fw)
-               release_firmware(fw);
+       release_firmware(fw);
 
        dev_dbg(&client->dev, "failed=%d\n", ret);
        return ret;