]> git.karo-electronics.de Git - linux-beck.git/commitdiff
cw1200: Remove useless return variables
authorPeter Senna Tschudin <peter.senna@gmail.com>
Sat, 31 May 2014 16:12:26 +0000 (13:12 -0300)
committerJohn W. Linville <linville@tuxdriver.com>
Thu, 19 Jun 2014 19:49:12 +0000 (15:49 -0400)
This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.

Verified by compilation only.

The coccinelle script that find and fixes this issue is:
// <smpl>
@@
type T;
constant C;
identifier ret;
@@
- T ret = C;
... when != ret
    when strict
return
- ret
+ C
;
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/cw1200/sta.c

index cd0cad7f775993661af9e8f4577c89976b15b811..5b84664db13b3c0c36d27d2ef74d87cff618b2c7 100644 (file)
@@ -2289,7 +2289,6 @@ static int cw1200_upload_null(struct cw1200_common *priv)
 
 static int cw1200_upload_qosnull(struct cw1200_common *priv)
 {
-       int ret = 0;
        /* TODO:  This needs to be implemented
 
        struct wsm_template_frame frame = {
@@ -2306,7 +2305,7 @@ static int cw1200_upload_qosnull(struct cw1200_common *priv)
        dev_kfree_skb(frame.skb);
 
        */
-       return ret;
+       return 0;
 }
 
 static int cw1200_enable_beaconing(struct cw1200_common *priv,