]> git.karo-electronics.de Git - linux-beck.git/commitdiff
[media] lirc_dev: remove double if ... else statement
authorAndi Shyti <andi.shyti@samsung.com>
Wed, 6 Jul 2016 09:01:20 +0000 (06:01 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Wed, 13 Jul 2016 18:09:05 +0000 (15:09 -0300)
There are two if ... else which check the same thing in different
part of the code, they can be merged in a single check.

Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/rc/lirc_dev.c

index c2826a7b70bd39c2a876a1fb59c14930a8cb4271..a8a5116d96691f0da106043d4e309ccac3e04d32 100644 (file)
@@ -310,13 +310,6 @@ static int lirc_allocate_driver(struct lirc_driver *d)
        irctls[minor] = ir;
        d->minor = minor;
 
-       if (d->sample_rate) {
-               ir->jiffies_to_wait = HZ / d->sample_rate;
-       } else {
-               /* it means - wait for external event in task queue */
-               ir->jiffies_to_wait = 0;
-       }
-
        /* some safety check 8-) */
        d->name[sizeof(d->name)-1] = '\0';
 
@@ -330,6 +323,8 @@ static int lirc_allocate_driver(struct lirc_driver *d)
                      "lirc%u", ir->d.minor);
 
        if (d->sample_rate) {
+               ir->jiffies_to_wait = HZ / d->sample_rate;
+
                /* try to fire up polling thread */
                ir->task = kthread_run(lirc_thread, (void *)ir, "lirc_dev");
                if (IS_ERR(ir->task)) {
@@ -338,6 +333,9 @@ static int lirc_allocate_driver(struct lirc_driver *d)
                        err = -ECHILD;
                        goto out_sysfs;
                }
+       } else {
+               /* it means - wait for external event in task queue */
+               ir->jiffies_to_wait = 0;
        }
 
        err = lirc_cdev_add(ir);